Added check to support a continuous run of a terminator to end a line#403
Merged
tleonhardt merged 3 commits intomasterfrom May 17, 2018
Merged
Added check to support a continuous run of a terminator to end a line#403tleonhardt merged 3 commits intomasterfrom
tleonhardt merged 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 89.48% 90.15% +0.66%
==========================================
Files 8 8
Lines 2530 2528 -2
==========================================
+ Hits 2264 2279 +15
+ Misses 266 249 -17
Continue to review full report at Codecov.
|
tleonhardt
previously approved these changes
May 16, 2018
| try: | ||
| pos = tokens.index(test_terminator) | ||
| if pos < terminator_pos: | ||
| terminator_pos = len(tokens) + 1 |
kotfu
suggested changes
May 16, 2018
Contributor
kotfu
left a comment
kotfu
left a comment
There was a problem hiding this comment.
I don't think we are quite there yet. I just committed a bunch of unit tests that I think should pass, and many of them don't.
kotfu
approved these changes
May 17, 2018
tleonhardt
approved these changes
May 17, 2018
| assert statement.argv == ['has', '>', 'inside'] | ||
| assert statement.terminator == ';' | ||
|
|
||
| @pytest.mark.parametrize('line,terminator',[ |
Member
There was a problem hiding this comment.
Thanks for adding lots of unit tests to cover this functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #402
This closes #402